Skip to content

Conversation

@Func86
Copy link
Contributor

@Func86 Func86 commented Nov 24, 2024

Summary

The step.sleep method for Workflows takes the number argument as milliseconds, instead of seconds as previously documented.
I tested and noticed this issue.

Screenshots (optional)

Documentation checklist

@github-actions github-actions bot added product:workflows Workflows: https://developers.cloudflare.com/workflows/ size/xs labels Nov 24, 2024
@elithrar elithrar enabled auto-merge (squash) February 19, 2025 13:00
@Func86
Copy link
Contributor Author

Func86 commented Feb 27, 2025

Merging is blocked
Merge is not an allowed merge method in this repository.

@elithrar What should I do?

@elithrar elithrar disabled auto-merge February 27, 2025 17:00
@elithrar
Copy link
Collaborator

cc @kodster28 since this seems stuck.

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 24, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated the documentation for the step.sleep method to clarify that the number argument is now interpreted as milliseconds instead of seconds.

  • Changed the argument type for step.sleep from seconds to milliseconds in the documentation.
  • Clarified the accepted units for the step.sleep method in the documentation.

Modified Files

  • src/content/docs/workflows/build/sleeping-and-retrying.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@kodster28
Copy link
Collaborator

ah, in the meantime looks like this already got solved

https://developers.cloudflare.com/workflows/build/sleeping-and-retrying/

@kodster28 kodster28 closed this Mar 24, 2025
@Func86 Func86 deleted the patch-1 branch March 24, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workflows Workflows: https://developers.cloudflare.com/workflows/ size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants